andygrove commented on PR #1683: URL: https://github.com/apache/datafusion-comet/pull/1683#issuecomment-2835047261
> Iceberg shades Parquet. In our internal version of Iceberg, we remove the shading. In OSS, when enabling Comet native execution in [apache/iceberg#12709](https://github.com/apache/iceberg/pull/12709), I actually unshaded Parquet, but I don't think that's the correct approach. > > Instead of passing a `ColumnDescriptor` from Iceberg to Comet, should we pass a String[] path, PrimitiveType.PrimitiveTypeName type, int maxRep, and int maxDef, so that we can construct the `ColumnDescriptor` on the Comet side? Thanks @huaxingao, I will try that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
