parthchandra commented on code in PR #1683: URL: https://github.com/apache/datafusion-comet/pull/1683#discussion_r2064055623
########## common/src/main/java/org/apache/comet/CometSchemaImporter.java: ########## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.comet; + +import org.apache.arrow.c.*; +import org.apache.arrow.memory.BufferAllocator; + +/** This is a simple wrapper around SchemaImporter to make it accessible from Java Arrow. */ +public class CometSchemaImporter extends AbstractCometSchemaImporter { Review Comment: Are we sure we do not break anything here? This class existed to overcome some package private restrictions in Arrow FFI (cannot remember what though). If it is safe to do so (i.e. the build does not break), it would make sense to move all the Comet classes in `org.apache.arrow.c` together. Maybe to `org.apache.comet.arrow`? Can be a followup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
