andygrove commented on PR #1683: URL: https://github.com/apache/datafusion-comet/pull/1683#issuecomment-2835258164
After modifying Iceberg to make `SparkBatchQueryScan` implement `SupportsComet`, this now appears to be fully working. ``` scala> spark.sql(s"SELECT * from t1").show() 25/04/28 07:29:37 INFO core/src/lib.rs: Comet native library version 0.9.0 initialized 25/04/28 07:29:37 WARN CometSparkSessionExtensions$CometExecRule: Comet cannot execute some parts of this plan natively (set spark.comet.explainFallback.enabled=false to disable this logging): CollectLimit [COMET: CollectLimit is not supported] +- Project [COMET: toprettystring is not supported] +- CometScanWrapper +---+---+ | c0| c1| +---+---+ | 0| 0| | 1| 1| | 2| 2| | 3| 3| | 4| 4| | 5| 5| | 6| 6| | 7| 7| | 8| 8| | 9| 9| | 10| 10| | 11| 11| | 12| 12| | 13| 13| | 14| 14| | 15| 15| | 16| 16| | 17| 17| | 18| 18| | 19| 19| +---+---+ only showing top 20 rows ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org