iffyio commented on code in PR #1810:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1810#discussion_r2067197344
##########
src/parser/mod.rs:
##########
@@ -5256,14 +5256,19 @@ impl<'a> Parser<'a> {
pub fn parse_create_trigger(
&mut self,
+ or_alter: bool,
or_replace: bool,
is_constraint: bool,
) -> Result<Statement, ParserError> {
- if !dialect_of!(self is PostgreSqlDialect | GenericDialect |
MySqlDialect) {
+ if !dialect_of!(self is PostgreSqlDialect | GenericDialect |
MySqlDialect | MsSqlDialect) {
self.prev_token();
return self.expected("an object type after CREATE",
self.peek_token());
}
+ if dialect_of!(self is MsSqlDialect) {
+ return self.parse_mssql_create_trigger(or_alter, or_replace,
is_constraint);
+ }
Review Comment:
ah yeah it would need to manually parse the alter, replace for the trigger,
I agree that its not ideal but its probably the lesser evil, see [snowflake
here for an
example](https://github.com/apache/datafusion-sqlparser-rs/blob/main/src/dialect/snowflake.rs#L144)
##########
src/parser/mod.rs:
##########
@@ -5256,14 +5256,19 @@ impl<'a> Parser<'a> {
pub fn parse_create_trigger(
&mut self,
+ or_alter: bool,
or_replace: bool,
is_constraint: bool,
) -> Result<Statement, ParserError> {
- if !dialect_of!(self is PostgreSqlDialect | GenericDialect |
MySqlDialect) {
+ if !dialect_of!(self is PostgreSqlDialect | GenericDialect |
MySqlDialect | MsSqlDialect) {
self.prev_token();
return self.expected("an object type after CREATE",
self.peek_token());
}
+ if dialect_of!(self is MsSqlDialect) {
+ return self.parse_mssql_create_trigger(or_alter, or_replace,
is_constraint);
+ }
Review Comment:
ah yeah it would need to manually parse the alter, replace for the trigger,
I agree that its not ideal but its probably the lesser evil, see [snowflake
here for an
example](https://github.com/apache/datafusion-sqlparser-rs/blob/main/src/dialect/snowflake.rs#L144)r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
