aharpervc commented on code in PR #1810:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1810#discussion_r2068726100
##########
src/dialect/mssql.rs:
##########
@@ -215,6 +218,78 @@ impl MsSqlDialect {
}))
}
+ /// Parse a SQL CREATE statement
+ fn parse_create(&self, parser: &mut Parser) -> Option<Result<Statement,
ParserError>> {
+ let original_index = parser.index();
+
+ if !parser.parse_keyword(Keyword::CREATE) {
+ parser.set_index(original_index);
Review Comment:
Great, I'll drop the maybe_parse commit & update the implementation to this
two branch approach. I think that will meet both our expectations for the time
being.
A pro/con on that iteration will be that the dialect implementation of
parse_statement is mixing peek & parse strategies in that function, which seems
unfortunate. However further refactoring it to consolidate strategies seems
outside the scope of the branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
