tomershaniii commented on code in PR #1747:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1747#discussion_r2067961343
##########
src/ast/helpers/stmt_create_table.rs:
##########
@@ -76,27 +78,20 @@ pub struct CreateTableBuilder {
pub constraints: Vec<TableConstraint>,
pub hive_distribution: HiveDistributionStyle,
pub hive_formats: Option<HiveFormat>,
- pub table_properties: Vec<SqlOption>,
- pub with_options: Vec<SqlOption>,
pub file_format: Option<FileFormat>,
pub location: Option<String>,
pub query: Option<Box<Query>>,
pub without_rowid: bool,
pub like: Option<ObjectName>,
pub clone: Option<ObjectName>,
- pub engine: Option<TableEngine>,
- pub comment: Option<CommentDef>,
- pub auto_increment_offset: Option<u32>,
- pub default_charset: Option<String>,
- pub collation: Option<String>,
+ pub comment_after_column_def: Option<CommentDef>,
Review Comment:
All dialects have the comment as part of the options, hence they are part of
the generic comment list.
Hive has a different definition of where the comment should be, previously
this was defined by an enum variant see
[here](https://github.com/apache/datafusion-sqlparser-rs/blob/a5b9821d1d2fa9c0b8ee73b698a2b0e5f138beaf/src/ast/mod.rs#L8847)
The previous 'generic comment' is now part of the generic list (SqlOption),
i believe the name should reflect this context (open to alternative names).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
