berkaysynnada commented on code in PR #15935:
URL: https://github.com/apache/datafusion/pull/15935#discussion_r2072391618
##########
datafusion/datasource-parquet/src/file_format.rs:
##########
@@ -464,16 +464,16 @@ impl FileFormat for ParquetFormat {
fn supports_filters_pushdown(
&self,
file_schema: &Schema,
- table_schema: &Schema,
Review Comment:
I'm a bit confused, as we talked like
"_keep supports_filters_pushdown so that TableProviders can do Exact pruning
of filters, e.g. using partition columns._",
and that is making sense to me now. So, instead, should we pass only
table_schema's to these `supports_filters_pushdown()` API's at ListingTable
level? Theory and practice conflict in my mind now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
