adriangb commented on code in PR #15935:
URL: https://github.com/apache/datafusion/pull/15935#discussion_r2072411339


##########
datafusion/datasource-parquet/src/file_format.rs:
##########
@@ -464,16 +464,16 @@ impl FileFormat for ParquetFormat {
     fn supports_filters_pushdown(
         &self,
         file_schema: &Schema,
-        table_schema: &Schema,

Review Comment:
   > instead, should we pass only table_schema's to these 
supports_filters_pushdown() API's at ListingTable level
   
   We could! But we'd do that in 
https://github.com/apache/datafusion/pull/15769 right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to