berkaysynnada commented on code in PR #15935:
URL: https://github.com/apache/datafusion/pull/15935#discussion_r2072414250
##########
datafusion/datasource-parquet/src/file_format.rs:
##########
@@ -464,16 +464,16 @@ impl FileFormat for ParquetFormat {
fn supports_filters_pushdown(
&self,
file_schema: &Schema,
- table_schema: &Schema,
Review Comment:
It doesn't change any API?
I mean can we remove `file_schema: &Schema` or `table_schema: &Schema`from
these `supports_filters_pushdown()` API's? If we can, which one should we
remove? In this PR, the fix shows that we utilize `file_schema: &Schema`,
however, what I understand from that conversation is we should depend on
`table_schema: &Schema`, not `file_schema: &Schema`. That's what confuses me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
