Rachelint commented on code in PR #15591:
URL: https://github.com/apache/datafusion/pull/15591#discussion_r2075218539
##########
datafusion/functions-aggregate-common/src/aggregate/groups_accumulator/prim_op.rs:
##########
@@ -93,20 +94,27 @@ where
opt_filter: Option<&BooleanArray>,
total_num_groups: usize,
) -> Result<()> {
Review Comment:
> Ah I see that batch size is used by default :). Yeah I think it makes
sense to test it a bit further, maybe for this a slightly larger value (e.g.
2x, 4x batch size) will be beneficial when the cardinality is above the batch
size.
>
> Also at some point might make sense to think of it in size in memory
instead of number of elements (e.g. block of `u8` values might hold 16x more
values than u128).
It is really a good idea to split block by size rather than num rows, I will
experiment on it after trying some exist ideas later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
