blaginin commented on code in PR #15871:
URL: https://github.com/apache/datafusion/pull/15871#discussion_r2080581411
##########
datafusion/functions-aggregate/src/count.rs:
##########
@@ -764,4 +774,49 @@ mod tests {
assert_eq!(accumulator.evaluate()?, ScalarValue::Int64(Some(0)));
Ok(())
}
+
+ #[test]
+ fn test_nested_dictionary() -> Result<()> {
Review Comment:
Worried about edge cases like dict of dicts, dict of lists, etc., but
couldn't come up with anything that breaks the function. Happy to be challenged
🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
