berkaysynnada commented on code in PR #14837:
URL: https://github.com/apache/datafusion/pull/14837#discussion_r2083486922
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -775,12 +776,44 @@ impl DefaultPhysicalPlanner {
let runtime_expr =
self.create_physical_expr(predicate, input_dfschema,
session_state)?;
+
+ let filter = match self.try_plan_async_exprs(
Review Comment:
> something like this perhaps
rewritten plan is (async_exec + original plan)?
> I think at a really high level this pattern is basically the same as the
["Common Subexpression
Elimination"](https://github.com/apache/datafusion/blob/main/datafusion/optimizer/src/common_subexpr_eliminate.rs)
and many of the other optimizer passes -- that is pulling some subset of the
expressions into a new node, and rewriting the others.
I see the pattern now, but IMO for this async evaluation, adding a new
operator for each async fn in the query seems a bit unnatural to me. I feel
like we should encapsulate this feature in PhysicalExpr's level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
