berkaysynnada commented on PR #14837: URL: https://github.com/apache/datafusion/pull/14837#issuecomment-2871247518
> 1. The async overhead (e.g. what it takes to make await vs a normal function) could be noticable, but maybe not that big a deal If the awaited task doesn't include any I/O work or manual yielding, I believe we won't see a visible change, but of course it must be proven. > 2. The fact that everything that calls UDF would have to be async (as only async functions can call other async functions) -- the so called ["what color are your functions" problem](https://journal.stuffwithstuff.com/2015/02/01/what-color-is-your-function/) -- we be quite disruptive. I think this is related to how we approach this feature. As you said, making evaluate() async introduces a conceptual change to datafusion. But if we aim to bring async evaluations to a unified point alongside sync evaluations and integrate them smoothly into DataFusion, some disruption is inevitable. That said, if we agree this is not a high-demand feature and this PR enables it while keeping things isolated, I'm fine with that too (though I'd still like to try and experiment with the idea 😇). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
