adriangb commented on code in PR #16148: URL: https://github.com/apache/datafusion/pull/16148#discussion_r2112148579
########## datafusion/datasource/src/test_util.rs: ########## @@ -81,6 +83,8 @@ impl FileSource for MockSource { fn file_type(&self) -> &str { "mock" } + + impl_schema_adapter_methods!(); Review Comment: I think it's better to ask users to implement a 1 liner with clear instructions in the upgrade guide and helpers to make the code simple than it is to try to hide that from them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org