kosiew commented on code in PR #16148:
URL: https://github.com/apache/datafusion/pull/16148#discussion_r2113115289
##########
datafusion/datasource/src/test_util.rs:
##########
@@ -81,6 +83,8 @@ impl FileSource for MockSource {
fn file_type(&self) -> &str {
"mock"
}
+
+ impl_schema_adapter_methods!();
Review Comment:
@alamb , @adriangb ,
Thanks for your discussion on this.
What do you think about implementing the schema adapter support via an
[opt-in
trait](https://github.com/apache/datafusion/pull/15295#discussion_r2100959986)
to avoid [breaking
changes](https://github.com/apache/datafusion/pull/16148#discussion_r2110769126)
in FileSource trait?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
