adriangb commented on code in PR #16148: URL: https://github.com/apache/datafusion/pull/16148#discussion_r2112147587
########## datafusion/datasource/src/test_util.rs: ########## @@ -81,6 +83,8 @@ impl FileSource for MockSource { fn file_type(&self) -> &str { "mock" } + + impl_schema_adapter_methods!(); Review Comment: Then I think we should do that. We can provide helper methods e.g. `no_op_method_name` such that users can do: ```rust fn method_that_I_now_need_to_implement(&self, ...) -> ... { no_op_helper(self) } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org