simonvandel commented on code in PR #1879:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1879#discussion_r2173772101
##########
src/parser/mod.rs:
##########
@@ -11142,6 +11200,217 @@ impl<'a> Parser<'a> {
let sample =
self.parse_table_sample(TableSampleModifier::TableSample)?;
pipe_operators.push(PipeOperator::TableSample { sample });
}
+ Keyword::RENAME => {
+ let mappings =
+
self.parse_comma_separated(Parser::parse_identifier_with_optional_alias)?;
+ pipe_operators.push(PipeOperator::Rename { mappings });
+ }
+ Keyword::UNION => {
+ let set_quantifier =
self.parse_set_quantifier(&Some(SetOperator::Union));
+ let queries = self.parse_pipe_operator_queries()?;
+ pipe_operators.push(PipeOperator::Union {
+ set_quantifier,
+ queries,
+ });
+ }
+ Keyword::INTERSECT => {
+ let set_quantifier =
+
self.parse_distinct_required_set_quantifier("INTERSECT")?;
+ let queries = self.parse_pipe_operator_queries()?;
+ pipe_operators.push(PipeOperator::Intersect {
+ set_quantifier,
+ queries,
+ });
+ }
+ Keyword::EXCEPT => {
+ let set_quantifier =
self.parse_distinct_required_set_quantifier("EXCEPT")?;
+ let queries = self.parse_pipe_operator_queries()?;
+ pipe_operators.push(PipeOperator::Except {
+ set_quantifier,
+ queries,
+ });
+ }
+ Keyword::CALL => {
+ let function_name = self.parse_object_name(false)?;
+ let function_expr = self.parse_function(function_name)?;
+ if let Expr::Function(function) = function_expr {
+ let alias = self.parse_optional_pipe_alias()?;
+ pipe_operators.push(PipeOperator::Call { function,
alias });
+ } else {
+ return Err(ParserError::ParserError(
+ "Expected function call after CALL".to_string(),
+ ));
+ }
+ }
+ Keyword::PIVOT => {
+ self.expect_token(&Token::LParen)?;
+ let aggregate_functions =
+
self.parse_comma_separated(Self::parse_aliased_function_call)?;
+ self.expect_keyword_is(Keyword::FOR)?;
+ let value_column = self.parse_period_separated(|p|
p.parse_identifier())?;
+ self.expect_keyword_is(Keyword::IN)?;
+
+ self.expect_token(&Token::LParen)?;
+ let value_source = if self.parse_keyword(Keyword::ANY) {
+ let order_by = if
self.parse_keywords(&[Keyword::ORDER, Keyword::BY]) {
+
self.parse_comma_separated(Parser::parse_order_by_expr)?
+ } else {
+ vec![]
+ };
+ PivotValueSource::Any(order_by)
+ } else if self.peek_sub_query() {
+ PivotValueSource::Subquery(self.parse_query()?)
+ } else {
+ PivotValueSource::List(
+
self.parse_comma_separated(Self::parse_expr_with_alias)?,
+ )
+ };
+ self.expect_token(&Token::RParen)?;
+ self.expect_token(&Token::RParen)?;
+
+ let alias = self.parse_optional_pipe_alias()?;
+
+ pipe_operators.push(PipeOperator::Pivot {
+ aggregate_functions,
+ value_column,
+ value_source,
+ alias,
+ });
+ }
+ Keyword::UNPIVOT => {
+ self.expect_token(&Token::LParen)?;
+ let value_column = self.parse_identifier()?;
+ self.expect_keyword(Keyword::FOR)?;
+ let name_column = self.parse_identifier()?;
+ self.expect_keyword(Keyword::IN)?;
+
+ self.expect_token(&Token::LParen)?;
+ let unpivot_columns =
self.parse_comma_separated(Parser::parse_identifier)?;
+ self.expect_token(&Token::RParen)?;
+
+ self.expect_token(&Token::RParen)?;
+
+ let alias = self.parse_optional_pipe_alias()?;
+
+ pipe_operators.push(PipeOperator::Unpivot {
+ value_column,
+ name_column,
+ unpivot_columns,
+ alias,
+ });
+ }
+ Keyword::JOIN => {
Review Comment:
Thanks,
https://github.com/apache/datafusion-sqlparser-rs/pull/1879/commits/324ad14701756dc7b4e0c67a8384697a197527c7
##########
src/parser/mod.rs:
##########
@@ -11142,6 +11200,217 @@ impl<'a> Parser<'a> {
let sample =
self.parse_table_sample(TableSampleModifier::TableSample)?;
pipe_operators.push(PipeOperator::TableSample { sample });
}
+ Keyword::RENAME => {
+ let mappings =
+
self.parse_comma_separated(Parser::parse_identifier_with_optional_alias)?;
+ pipe_operators.push(PipeOperator::Rename { mappings });
+ }
+ Keyword::UNION => {
+ let set_quantifier =
self.parse_set_quantifier(&Some(SetOperator::Union));
+ let queries = self.parse_pipe_operator_queries()?;
+ pipe_operators.push(PipeOperator::Union {
+ set_quantifier,
+ queries,
+ });
+ }
+ Keyword::INTERSECT => {
+ let set_quantifier =
+
self.parse_distinct_required_set_quantifier("INTERSECT")?;
+ let queries = self.parse_pipe_operator_queries()?;
+ pipe_operators.push(PipeOperator::Intersect {
+ set_quantifier,
+ queries,
+ });
+ }
+ Keyword::EXCEPT => {
+ let set_quantifier =
self.parse_distinct_required_set_quantifier("EXCEPT")?;
+ let queries = self.parse_pipe_operator_queries()?;
+ pipe_operators.push(PipeOperator::Except {
+ set_quantifier,
+ queries,
+ });
+ }
+ Keyword::CALL => {
+ let function_name = self.parse_object_name(false)?;
+ let function_expr = self.parse_function(function_name)?;
+ if let Expr::Function(function) = function_expr {
+ let alias = self.parse_optional_pipe_alias()?;
+ pipe_operators.push(PipeOperator::Call { function,
alias });
+ } else {
+ return Err(ParserError::ParserError(
+ "Expected function call after CALL".to_string(),
+ ));
+ }
+ }
+ Keyword::PIVOT => {
+ self.expect_token(&Token::LParen)?;
+ let aggregate_functions =
+
self.parse_comma_separated(Self::parse_aliased_function_call)?;
+ self.expect_keyword_is(Keyword::FOR)?;
+ let value_column = self.parse_period_separated(|p|
p.parse_identifier())?;
+ self.expect_keyword_is(Keyword::IN)?;
+
+ self.expect_token(&Token::LParen)?;
+ let value_source = if self.parse_keyword(Keyword::ANY) {
+ let order_by = if
self.parse_keywords(&[Keyword::ORDER, Keyword::BY]) {
+
self.parse_comma_separated(Parser::parse_order_by_expr)?
+ } else {
+ vec![]
+ };
+ PivotValueSource::Any(order_by)
+ } else if self.peek_sub_query() {
+ PivotValueSource::Subquery(self.parse_query()?)
+ } else {
+ PivotValueSource::List(
+
self.parse_comma_separated(Self::parse_expr_with_alias)?,
+ )
+ };
+ self.expect_token(&Token::RParen)?;
+ self.expect_token(&Token::RParen)?;
+
+ let alias = self.parse_optional_pipe_alias()?;
+
+ pipe_operators.push(PipeOperator::Pivot {
+ aggregate_functions,
+ value_column,
+ value_source,
+ alias,
+ });
+ }
+ Keyword::UNPIVOT => {
+ self.expect_token(&Token::LParen)?;
+ let value_column = self.parse_identifier()?;
+ self.expect_keyword(Keyword::FOR)?;
+ let name_column = self.parse_identifier()?;
+ self.expect_keyword(Keyword::IN)?;
+
+ self.expect_token(&Token::LParen)?;
+ let unpivot_columns =
self.parse_comma_separated(Parser::parse_identifier)?;
+ self.expect_token(&Token::RParen)?;
+
+ self.expect_token(&Token::RParen)?;
+
+ let alias = self.parse_optional_pipe_alias()?;
+
+ pipe_operators.push(PipeOperator::Unpivot {
+ value_column,
+ name_column,
+ unpivot_columns,
+ alias,
+ });
+ }
+ Keyword::JOIN => {
+ let relation = self.parse_table_factor()?;
+ let constraint = self.parse_join_constraint(false)?;
+ if matches!(constraint, JoinConstraint::None) {
+ return Err(ParserError::ParserError(
+ "JOIN in pipe syntax requires ON or USING
clause".to_string(),
+ ));
+ }
Review Comment:
Removed in
https://github.com/apache/datafusion-sqlparser-rs/pull/1879/commits/324ad14701756dc7b4e0c67a8384697a197527c7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
