simonvandel commented on code in PR #1879:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1879#discussion_r2173771543
##########
src/ast/query.rs:
##########
@@ -2739,7 +2812,91 @@ impl fmt::Display for PipeOperator {
PipeOperator::TableSample { sample } => {
write!(f, "{}", sample)
}
+ PipeOperator::Rename { mappings } => {
+ write!(f, "RENAME {}", display_comma_separated(mappings))
+ }
+ PipeOperator::Union {
+ set_quantifier,
+ queries,
+ } => Self::fmt_set_operation(f, "UNION", set_quantifier, queries),
+ PipeOperator::Intersect {
+ set_quantifier,
+ queries,
+ } => Self::fmt_set_operation(f, "INTERSECT", set_quantifier,
queries),
+ PipeOperator::Except {
+ set_quantifier,
+ queries,
+ } => Self::fmt_set_operation(f, "EXCEPT", set_quantifier, queries),
+ PipeOperator::Call { function, alias } => {
+ write!(f, "CALL {}", function)?;
+ Self::fmt_optional_alias(f, alias)
+ }
+ PipeOperator::Pivot {
+ aggregate_functions,
+ value_column,
+ value_source,
+ alias,
+ } => {
+ write!(
+ f,
+ "PIVOT({} FOR {} IN ({}))",
+ display_comma_separated(aggregate_functions),
+ Expr::CompoundIdentifier(value_column.to_vec()),
+ value_source
+ )?;
+ Self::fmt_optional_alias(f, alias)
+ }
+ PipeOperator::Unpivot {
+ value_column,
+ name_column,
+ unpivot_columns,
+ alias,
+ } => {
+ write!(
+ f,
+ "UNPIVOT({} FOR {} IN ({}))",
+ value_column,
+ name_column,
+ display_comma_separated(unpivot_columns)
+ )?;
+ Self::fmt_optional_alias(f, alias)
+ }
+ PipeOperator::Join(join) => write!(f, "{}", join),
+ }
+ }
+}
+
+impl PipeOperator {
+ /// Helper function to format optional alias for pipe operators
+ fn fmt_optional_alias(f: &mut fmt::Formatter<'_>, alias: &Option<Ident>)
-> fmt::Result {
+ if let Some(alias) = alias {
+ write!(f, " AS {}", alias)?;
}
+ Ok(())
+ }
+
+ /// Helper function to format set operations (UNION, INTERSECT, EXCEPT)
with queries
+ fn fmt_set_operation(
+ f: &mut fmt::Formatter<'_>,
+ operation: &str,
+ set_quantifier: &SetQuantifier,
+ queries: &[Query],
+ ) -> fmt::Result {
+ write!(f, "{}", operation)?;
+ match set_quantifier {
+ SetQuantifier::None => {}
+ _ => {
+ write!(f, " {}", set_quantifier)?;
+ }
+ }
+ write!(f, " ")?;
+ for (i, query) in queries.iter().enumerate() {
+ if i > 0 {
+ write!(f, ", ")?;
+ }
+ write!(f, "({})", query)?;
+ }
Review Comment:
Thanks,
https://github.com/apache/datafusion-sqlparser-rs/pull/1879/commits/18ea4ba7c84038c5285420c75d0bd53f44161412
and
https://github.com/apache/datafusion-sqlparser-rs/pull/1879/commits/330a9252afb0b6f637d92cc8b4df4e738ad9ffb3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
