findepi commented on code in PR #16183:
URL: https://github.com/apache/datafusion/pull/16183#discussion_r2228350408
##########
datafusion/sqllogictest/bin/sqllogictests.rs:
##########
@@ -138,8 +140,22 @@ async fn run_tests() -> Result<()> {
let filters = options.filters.clone();
SpawnedTask::spawn(async move {
- match (options.postgres_runner, options.complete) {
- (false, false) => {
+ match (
+ options.postgres_runner,
+ options.complete,
+ options.substrait_round_trip,
+ ) {
+ (_, _, true) => {
+ run_test_file_substrait_round_trip(
+ test_file,
+ validator,
+ m_clone,
+ m_style_clone,
+ filters.as_ref(),
Review Comment:
Don't ignore postgres_runner and complete arguments.
Unsupported arg combinations should be an error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
