findepi commented on code in PR #16183:
URL: https://github.com/apache/datafusion/pull/16183#discussion_r2229222493
##########
datafusion/sqllogictest/bin/sqllogictests.rs:
##########
@@ -138,8 +140,22 @@ async fn run_tests() -> Result<()> {
let filters = options.filters.clone();
SpawnedTask::spawn(async move {
- match (options.postgres_runner, options.complete) {
- (false, false) => {
+ match (
+ options.postgres_runner,
+ options.complete,
+ options.substrait_round_trip,
+ ) {
+ (_, _, true) => {
+ run_test_file_substrait_round_trip(
+ test_file,
+ validator,
+ m_clone,
+ m_style_clone,
+ filters.as_ref(),
Review Comment:
good point and i haven't checked that
in the past i've observed some param combinations being ignored...
it's best if the clap does that (prints best error messages), but IMO the
code further down should not rely on clap validation (think: args struct could
come from some other source) and thus should re-validate.
anyway, that's a nit, since we have the clap validation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
