gabotechs commented on code in PR #16183:
URL: https://github.com/apache/datafusion/pull/16183#discussion_r2228450157
##########
datafusion/sqllogictest/bin/sqllogictests.rs:
##########
@@ -138,8 +140,22 @@ async fn run_tests() -> Result<()> {
let filters = options.filters.clone();
SpawnedTask::spawn(async move {
- match (options.postgres_runner, options.complete) {
- (false, false) => {
+ match (
+ options.postgres_runner,
+ options.complete,
+ options.substrait_round_trip,
+ ) {
+ (_, _, true) => {
+ run_test_file_substrait_round_trip(
+ test_file,
+ validator,
+ m_clone,
+ m_style_clone,
+ filters.as_ref(),
Review Comment:
I think clap should be taking care of that
https://github.com/apache/datafusion/blob/76ff87b132b62edac207bb1105836a52d32d269e/datafusion/sqllogictest/bin/sqllogictests.rs#L636-L642
As suggested in
https://github.com/apache/datafusion/pull/16183#discussion_r2125481070.
If you try to run incompatible commands you would get something like this:
```
error: the argument '--substrait-round-trip' cannot be used with '--complete'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
