lorenarosati commented on code in PR #16984: URL: https://github.com/apache/datafusion/pull/16984#discussion_r2252134524
########## datafusion/substrait/src/logical_plan/consumer/expr/scalar_function.rs: ########## Review Comment: I realized that on line 44, we already consume the arguments. I was going to create a helper function to do the repetitive operation done in build_unary_expr, build_like_expr, etc (the pattern mentioned in your previous comment @vbarua). but I realized it seems redundant to be even doing this at all when it was already done in from_scalar_function. Let me know if this doesn't make sense or I should change this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
