alamb commented on code in PR #16984:
URL: https://github.com/apache/datafusion/pull/16984#discussion_r2258218040
##########
datafusion/substrait/src/logical_plan/producer/expr/scalar_function.rs:
##########
@@ -34,6 +34,8 @@ pub fn from_scalar_function(
});
}
+ let arguments = custom_argument_handler(fun.name(), arguments);
Review Comment:
I think this is ok for now -- I think it is somewhat suspicious that
`custom_argument_handler` has a special case for `log` -- it would be nicer to
keep all the log specific stuff together but I also think we can improve that
in a follow on PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
