lorenarosati commented on code in PR #16984:
URL: https://github.com/apache/datafusion/pull/16984#discussion_r2252198453
##########
datafusion/substrait/src/logical_plan/producer/expr/scalar_function.rs:
##########
@@ -34,6 +34,8 @@ pub fn from_scalar_function(
});
}
+ let arguments = custom_argument_handler(fun.name(), arguments);
Review Comment:
In earlier commits, I included a struct that handles things in a similar
manner to the BuiltinExprBuilder on the consumer side, but I figured it was
unnecessary given that this handling is pretty specific to log and changed it
to this. Let me know if you think I should do something more like that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
