andygrove commented on code in PR #2063:
URL: https://github.com/apache/datafusion-comet/pull/2063#discussion_r2254928955
##########
spark/src/main/scala/org/apache/comet/serde/hash.scala:
##########
@@ -65,6 +65,29 @@ object CometMurmur3Hash extends CometExpressionSerde {
}
}
+object CometSha2 extends CometExpressionSerde {
+ override def convert(
+ expr: Expression,
+ inputs: Seq[Attribute],
+ binding: Boolean): Option[ExprOuterClass.Expr] = {
+ if (!HashUtils.isSupportedType(expr)) {
+ return None
Review Comment:
nit: It would be good to add a `withInfo` call to record the fallback reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
