rishvin commented on code in PR #2063:
URL: https://github.com/apache/datafusion-comet/pull/2063#discussion_r2285768026
##########
spark/src/main/scala/org/apache/comet/serde/hash.scala:
##########
@@ -65,6 +65,29 @@ object CometMurmur3Hash extends CometExpressionSerde {
}
}
+object CometSha2 extends CometExpressionSerde {
+ override def convert(
+ expr: Expression,
+ inputs: Seq[Attribute],
+ binding: Boolean): Option[ExprOuterClass.Expr] = {
+ if (!HashUtils.isSupportedType(expr)) {
+ return None
+ }
+
+ // It's possible for spark to dynamically compute the number of bits from
input
+ // expression, however DataFusion does not support that yet.
+ val sha2Expr = expr.asInstanceOf[Sha2]
+ if (!sha2Expr.right.foldable) {
+ withInfo(expr, "For Sha2, non-foldable right argument is not supported")
Review Comment:
Created https://github.com/apache/datafusion-comet/issues/2193. Will fix
this later this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
