alamb commented on code in PR #17092:
URL: https://github.com/apache/datafusion/pull/17092#discussion_r2265210412
##########
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##########
@@ -103,6 +103,7 @@ pub struct ExprSimplifier<S> {
/// Should expressions be canonicalized before simplification? Defaults to
/// true
canonicalize: bool,
+ evaluate_constants: bool,
Review Comment:
Can you please also document what this field means and that its default is
true and that it is used for testing?
##########
datafusion/sqllogictest/test_files/predicates.slt:
##########
@@ -811,5 +811,26 @@ explain select x from t where x NOT IN (1,2,3,4,5) AND x
IN (1,2,3);
logical_plan EmptyRelation
physical_plan EmptyExec
+query error DataFusion error: This feature is not implemented: Physical plan
does not support logical expression InSubquery\(InSubquery \{ expr:
Literal\(Int64\(NULL\), None\), subquery: <subquery>, negated: false \}\)
Review Comment:
I confirmed these tests pass even without the code in this PR, as you
mention in the description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
