alamb commented on code in PR #17092:
URL: https://github.com/apache/datafusion/pull/17092#discussion_r2266505749
##########
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##########
@@ -3949,6 +3949,56 @@ mod tests {
assert_eq!(simplify(expr.clone()), expr);
}
+ #[test]
+ fn simplify_null_in_empty_inlist() {
+ // `NULL::boolean IN ()` == `NULL::boolean IN (SELECT foo FROM empty)`
== false
+ let expr = in_list(lit_bool_null(), vec![], false);
+ assert_eq!(simplify(expr), lit(false));
+
+ // `NULL::boolean NOT IN ()` == `NULL::boolean NOT IN (SELECT foo FROM
empty)` == true
+ let expr = in_list(lit_bool_null(), vec![], true);
+ assert_eq!(simplify(expr), lit(true));
+
+ // `NULL IN ()` == `NULL IN (SELECT foo FROM empty)` == false
+ let null_null = || Expr::Literal(ScalarValue::Null, None);
+ let expr = in_list(null_null(), vec![], false);
+ assert_eq!(simplify(expr), lit(false));
+
+ // `NULL NOT IN ()` == `NULL NOT IN (SELECT foo FROM empty)` == true
+ let expr = in_list(null_null(), vec![], true);
+ assert_eq!(simplify(expr), lit(true));
+ }
+
+ #[test]
Review Comment:
thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
