findepi commented on PR #17092: URL: https://github.com/apache/datafusion/pull/17092#issuecomment-3172538747
> Is it posisble to just unit test the code in question -- for example, perhaps we could write a unit test that used `Simplifier` directly rather than `ExprSimplifier` 🤔 One can argue that one is an impl detail of the other... are there any tests for `Simplifier`? > It is unfortunate that we need to complicate the actual code to add a testing hook. we can go without a _regression_ test for this fix. testing `Simplifier` directly and not `ExprSimplifier` would not constitute a regression test anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
