adriangb commented on PR #17090: URL: https://github.com/apache/datafusion/pull/17090#issuecomment-3191433426
This is a monumental piece of work, I’m astounded! Thank you so much for working on this. I’ll try to review it but I immediately will ask if we can somehow split it up into multiple logical PRs to make it easier to review and isolate future issues that may pop up. I’m also wondering if you’ve seen https://github.com/apache/datafusion/issues/17196 and https://github.com/apache/datafusion/issues/17188. I imagine this PR may fix them but it would be nice to fix those bugs first with a more targeted change / smaller PR first before adding more complexity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
