mbutrovich commented on code in PR #2099:
URL: https://github.com/apache/datafusion-comet/pull/2099#discussion_r2285923215
##########
native/spark-expr/src/static_invoke/char_varchar_utils/read_side_padding.rs:
##########
@@ -71,44 +100,78 @@ fn spark_read_side_padding2(
}
}
+enum RPadArgument {
Review Comment:
Why do we need a new `enum` type instead of relying on `ColumnarValue` when
can already represent a scalar or array?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
