ding-young commented on code in PR #17163:
URL: https://github.com/apache/datafusion/pull/17163#discussion_r2286847715
##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -415,6 +492,8 @@ impl ExternalSorter {
(*max_record_batch_size).max(batch.get_sliced_size()?);
}
+ self.reservation.free();
+
Review Comment:
I changed the timing of when the memory reservation is released; from before
spilling to after the spill is completed. Do you think this change is safe or
should I keep the original order (release before spill)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
