ding-young commented on code in PR #17163:
URL: https://github.com/apache/datafusion/pull/17163#discussion_r2286844750
##########
datafusion/core/tests/memory_limit/mod.rs:
##########
@@ -313,11 +313,9 @@ async fn sort_spill_reservation() {
// the sort will fail while trying to merge
.with_sort_spill_reservation_bytes(1024);
+ // TODO since we col->row conversion first, sort succeeds without limited
sort_spill_reservation_bytes
test.clone()
- .with_expected_errors(vec![
- "Resources exhausted: Additional allocation failed with top memory
consumers (across reservations) as:",
- "B for ExternalSorterMerge",
- ])
+ .with_expected_success()
Review Comment:
I'm wondering whether the `sort_spill_reservation_bytes` configuration will
still be necessary after this change. Since we're now estimating the memory
required for the merge phase based on the actual ratio measured from the first
batch, the manual override may become less important in practice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
