andygrove commented on code in PR #2236:
URL: https://github.com/apache/datafusion-comet/pull/2236#discussion_r2301444756
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -1524,6 +1525,11 @@ object QueryPlanSerde extends Logging with CometExprShim
{
withInfo(expr, s"${expr.prettyName} is not supported",
expr.children: _*)
None
}
+ case mapFilter : MapFilter =>
+ val mapExpr = exprToProtoInternal(mapFilter.input, inputs)
+ val lambdaExpr = exprToProtoInternal(mapFilter.function, inputs)
+ val optExpr = scalarFunctionExprToProtoWithReturnType("map_filter",
mapFilter.dataType, mapExpr, lambdaExpr)
+ optExprWithInfo(optExpr, expr, mapFilter.input, mapFilter.function)
Review Comment:
This isn't needed because the serde logic is already implemented in
`CometMapFilter`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
