rishvin commented on code in PR #2236:
URL: https://github.com/apache/datafusion-comet/pull/2236#discussion_r2302719310
##########
spark/src/main/scala/org/apache/comet/serde/maps.scala:
##########
@@ -89,3 +89,21 @@ object CometMapFromArrays extends
CometExpressionSerde[MapFromArrays] {
optExprWithInfo(mapFromArraysExpr, expr, expr.children: _*)
}
}
+
+object CometMapFilter extends CometExpressionSerde[MapFilter] {
+
+ override def convert(
+ expr: MapFilter,
+ inputs: Seq[Attribute],
+ binding: Boolean): Option[ExprOuterClass.Expr] = {
+ val mapExpr = exprToProtoInternal(expr.argument, inputs, binding)
+ val lambdaExpr = exprToProtoInternal(expr.function, inputs, binding)
Review Comment:
Do we also need something like `CometLambdaFunction` expression which will
be equivalent of Spark LambdaFunction expression defined
[here](https://github.com/apache/spark/blob/a9d6919ef45c49cf415320902ac2e2c53e5375dc/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala#L524)
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
