zhuqi-lucas opened a new pull request, #17706:
URL: https://github.com/apache/datafusion/pull/17706

   …will fail DFSchema construct
   
   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   - Closes [#17662](https://github.com/apache/datafusion/issues/17662)
   
   ## Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in 
the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your 
changes and offer better suggestions for fixes.  
   -->
   
   ## What changes are included in this PR?
   
   After the PR since apache datafusion 50.0.0, we will have name check for 
DFSchema construct:
   
   https://github.com/apache/datafusion/pull/17189
   
   Details:
   https://github.com/apache/datafusion/pull/17189/files#r2277001021
   
   But Partial AggregateMode will generate duplicate field names which will 
fail DFSchema construct, in our production we use lower level to do this.
   
   This PR relax DFSchema construct behaviour to support duplicate field names.
   
   
   
   ## Are these changes tested?
   Yes, unit test added.
   
   ## Are there any user-facing changes?
   
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to