xudong963 commented on code in PR #17706:
URL: https://github.com/apache/datafusion/pull/17706#discussion_r2367249918
##########
datafusion/common/src/dfschema.rs:
##########
@@ -1129,7 +1129,9 @@ impl TryFrom<SchemaRef> for DFSchema {
field_qualifiers: vec![None; field_count],
functional_dependencies: FunctionalDependencies::empty(),
};
- dfschema.check_names()?;
+ // Without checking names, because schema here may have duplicate
field names.
+ // For example, Partial AggregateMode will generate duplicate field
names from
+ // state_fields.
Review Comment:
Is it possible to dedup fileds after the "Partial AggregateMode"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
