zhuqi-lucas commented on code in PR #17706:
URL: https://github.com/apache/datafusion/pull/17706#discussion_r2367282766
##########
datafusion/common/src/dfschema.rs:
##########
@@ -1129,7 +1129,9 @@ impl TryFrom<SchemaRef> for DFSchema {
field_qualifiers: vec![None; field_count],
functional_dependencies: FunctionalDependencies::empty(),
};
- dfschema.check_names()?;
+ // Without checking names, because schema here may have duplicate
field names.
+ // For example, Partial AggregateMode will generate duplicate field
names from
+ // state_fields.
Review Comment:
Thanks @xudong963 , it should be better way, but i am not sure if it will
affect other part which using Partial Aggregate. So i keep the same behaviour
as DF 49 here.
For example, we need to deduplicate it to change state_fields, so we will
make order by field and is_set to different values, but i am not sure if it
will introduce new bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
