alamb commented on code in PR #17911:
URL: https://github.com/apache/datafusion/pull/17911#discussion_r2403909593
##########
datafusion/proto/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -2659,16 +2660,24 @@ async fn roundtrip_custom_listing_tables_schema() ->
Result<()> {
.infer_schema(&ctx.state())
.await?;
- ctx.register_table("hive_style",
Arc::new(ListingTable::try_new(config)?))?;
+ let listing_table: Arc<dyn TableProvider> =
Arc::new(ListingTable::try_new(config)?);
- let plan = ctx
Review Comment:
Can you please leave the existing test case so it is clear there is no loss
of coverage, and add the new plan as a new test case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
