mach-kernel commented on code in PR #17911:
URL: https://github.com/apache/datafusion/pull/17911#discussion_r2407951640
##########
datafusion/proto/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -2659,16 +2660,24 @@ async fn roundtrip_custom_listing_tables_schema() ->
Result<()> {
.infer_schema(&ctx.state())
.await?;
- ctx.register_table("hive_style",
Arc::new(ListingTable::try_new(config)?))?;
+ let listing_table: Arc<dyn TableProvider> =
Arc::new(ListingTable::try_new(config)?);
- let plan = ctx
Review Comment:
I added a new test alongside the existing one. The difference between the
tests is that the new one will have its projection pushed down to the
`TableScan` node whereas the original doesn't, which covers the projection case
for this bug.
I could not figure out what kind of assertion change to make to the existing
test (it will continue to pass with/without these changes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
