mach-kernel commented on code in PR #17911:
URL: https://github.com/apache/datafusion/pull/17911#discussion_r2404110408
##########
datafusion/proto/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -2659,16 +2660,24 @@ async fn roundtrip_custom_listing_tables_schema() ->
Result<()> {
.infer_schema(&ctx.state())
.await?;
- ctx.register_table("hive_style",
Arc::new(ListingTable::try_new(config)?))?;
+ let listing_table: Arc<dyn TableProvider> =
Arc::new(ListingTable::try_new(config)?);
- let plan = ctx
Review Comment:
The original test passes for me (where it should fail, after `cargo clean`)
on `main` refs:
- `daeb6597a0c7344735460bb2dce13879fd89d7bd`
- `182d5dc5e456322664da921f446018a0549e60bc`
At any rate, the old plan was 'supposed' to be the new plan! I am happy to
make the change if I got this wrong, just wanted to double check 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
