andygrove commented on code in PR #2595:
URL: https://github.com/apache/datafusion-comet/pull/2595#discussion_r2445168046
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -1385,23 +1385,25 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
testDoubleScalarExpr("expm1")
}
- // https://github.com/apache/datafusion-comet/issues/666
- ignore("abs") {
- Seq(true, false).foreach { dictionaryEnabled =>
- withTempDir { dir =>
- val path = new Path(dir.toURI.toString, "test.parquet")
- makeParquetFileAllPrimitiveTypes(path, dictionaryEnabled =
dictionaryEnabled, 100)
- withParquetTable(path.toString, "tbl") {
- Seq(2, 3, 4, 5, 6, 7, 9, 10, 11, 12, 15, 16, 17).foreach { col =>
- checkSparkAnswerAndOperator(s"SELECT abs(_${col}) FROM tbl")
+ test("abs") {
Review Comment:
I'd prefer to see this test added to `CometFuzzMathSuite` because the
generated Parquet file there tests for specific edge cases such as negative
floating point zero and min/max values for all types. The data generated by
`makeParquetFileAllPrimitiveTypes` does not explicitly add these edge cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
