andygrove commented on code in PR #2595:
URL: https://github.com/apache/datafusion-comet/pull/2595#discussion_r2445175840
##########
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##########
@@ -504,10 +504,10 @@ abstract class CometTestBase
| optional float _6;
| optional double _7;
| optional binary _8(UTF8);
- | optional int32 _9(UINT_8);
- | optional int32 _10(UINT_16);
- | optional int32 _11(UINT_32);
- | optional int64 _12(UINT_64);
+ | optional int32 _9(INT_8);
Review Comment:
I commented in
https://github.com/apache/datafusion-comet/pull/2595/files#r2445168046 but I
don't think that we should continue writing new tests that rely on
`makeParquetFileAllPrimitiveTypes` because it doesn't explicitly generate edge
case values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
