pepijnve commented on PR #18152: URL: https://github.com/apache/datafusion/pull/18152#issuecomment-3452377500
> Looks pretty good to me, left some comments, once resolved I can approve I think I got 'em all except for the `break` suggestion. I would prefer to leave that as is so all the early exits follow the same and we don't need any special safety checks or assertions after the when/then loop. The duplicated calls to `finish` aren't ideal, but I feel this is better than the alternative. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
