rluvaton commented on code in PR #18152:
URL: https://github.com/apache/datafusion/pull/18152#discussion_r2466493962
##########
datafusion/physical-expr/src/expressions/case.rs:
##########
@@ -383,15 +396,15 @@ impl ResultBuilder {
///
/// ```text
/// ┌─────────┐ ┌─────────┐┌───────────┐
┌─────────┐┌───────────┐
- /// │ C │ │ MAX ││┌─────────┐│ │
MAX ││┌─────────┐│
+ /// │ C │ │ None ││┌─────────┐│ │
None ││┌─────────┐│
/// ├─────────┤ ├─────────┤││ A ││
├─────────┤││ A ││
- /// │ D │ │ MAX ││└─────────┘│ │
2 ││└─────────┘│
+ /// │ D │ │ None ││└─────────┘│ │
2 ││└─────────┘│
/// └─────────┘ ├─────────┤│┌─────────┐│ add_branch_result(
├─────────┤│┌─────────┐│
/// value │ 0 │││ B ││ row indices, │
0 │││ B ││
/// ├─────────┤│└─────────┘│ value
├─────────┤│└─────────┘│
- /// │ MAX ││ │ ) │
MAX ││┌─────────┐│
+ /// │ None ││ │ ) │
None ││┌─────────┐│
/// ┌─────────┐ ├─────────┤│ │ ─────────────────────────▶
├─────────┤││ C ││
- /// │ 1 │ │ MAX ││ │ │
2 ││├─────────┤│
+ /// │ 1 │ │ None ││ │ │
2 ││├─────────┤│
/// ├─────────┤ ├─────────┤│ │
├─────────┤││ D ││
/// │ 4 │ │ 1 ││ │ │
1 ││└─────────┘│
Review Comment:
I've read the comment multiple times but having trouble understanding where
the 4 went?
are the `value` `[A, D]` is the value at the indices 1 and 4?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
