jizezhang commented on issue #17964: URL: https://github.com/apache/datafusion/issues/17964#issuecomment-3479051534
Hi @Jefffrey I was looking at some of the pairs and and have some questions: - For `rint -> round`, from what I understand, `rint` uses float [`round_ties_even`](https://doc.rust-lang.org/std/primitive.f32.html#method.round_ties_even) while `round` uses float [`round`](https://doc.rust-lang.org/std/primitive.f32.html#method.round), which would produce difference results for floats half-way between integers. Is that intended, or what was the reason? - For `array -> make_array`, - I did not seem to find unit tests in `datafusion/functions-nested/src/make_array.rs` or `datafusion/spark/src/functions/spark_array.rs`. Are tests kept in other files? - For `coalesce_types`, `make_array` uses `type_union_resolution` while `spark_array` uses `comparison_coersion` (with folding), both of which are implemented in `datafusion_expr_common::type_coercion::binary`. It seems to me that they are very similar for the purpose of coalescing types and `make_array` can also use `comparison_coersion`, but wanted to check in case I misunderstood anything. Also are there unit tests for `type_union_resolution`? did not seem to find under `type_coercion::binary` module. - `make_array` uses field name `LIST_FIELD_DEFAULT_NAME` (which is "item") while `spark_array` uses field name `ARRAY_FIELD_DEFAULT_NAME` (which is "element"). Are they intended to be different? - `make_array` does not handle case for `DataType::LargeList` while `spark_array` does. Is there a reason for that? Thanks a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
