jizezhang commented on issue #17964: URL: https://github.com/apache/datafusion/issues/17964#issuecomment-3483931002
@Jefffrey Thanks a lot for the detailed response! For `array` I'll start with what you suggested: >Might be worth mocking an example test which could exhibit this bug (where it returns a LargeList in spite of it stating its return type as regular List) For `rint/round`, I think [this](https://github.com/apache/datafusion/pull/16924) is the PR for `rint` and [this](https://github.com/apache/datafusion/pull/5807) is the initial PR for `round`. Neither seems to state the reason for choice of rounding function, though the commit for `rint` did include tests for floats half-way between integers while the commit for`round` did not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
