alamb commented on code in PR #18468:
URL: https://github.com/apache/datafusion/pull/18468#discussion_r2487975388
##########
datafusion/common/src/hash_utils.rs:
##########
@@ -140,6 +140,7 @@ fn hash_array_primitive<T>(
/// If `rehash==true` this combines the previous hash value in the buffer
/// with the new hash using `combine_hashes`
#[cfg(not(feature = "force_hash_collisions"))]
+#[allow(clippy::needless_pass_by_value)]
Review Comment:
Why is this needed? What is clippy's alternate suggestion?
##########
datafusion/common/src/column.rs:
##########
@@ -382,6 +382,7 @@ mod tests {
use arrow::datatypes::{DataType, SchemaBuilder};
use std::sync::Arc;
+ #[allow(clippy::needless_pass_by_value)]
fn create_qualified_schema(qualifier: &str, names: Vec<&str>) ->
Result<DFSchema> {
Review Comment:
we could change this to `impl IntoIterator<Item = &str>` for example
```suggestion
fn create_qualified_schema(qualifier: &str, names: impl
IntoIterator<Item = &str>) -> Result<DFSchema> {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
