2010YOUY01 commented on PR #18468: URL: https://github.com/apache/datafusion/pull/18468#issuecomment-3485053987
> Thank you @2010YOUY01 -- I think this looks like an improvement to me > > If we are going to add this lint I think we should also update the various APIs to pass (not just add ` #[allow(clippy::needless_pass_by_value)]` > > > If this PR makes sense, we can open a tracking issue and roll out this check to the remaining workspace packages. At least this can help prevent new inefficient patterns and identify existing issues that we can fix gradually. > > I think it makes a lot of sense Thank you for the feedbacks! For the following cases, I kept the ` #[allow(clippy::needless_pass_by_value)]` to suppress it - Tests. I think this rule do seem a bit annoying for tests, and I couldn't find a way to turn it off for all test modules...however we can apply the suppressing macro for individual test modules. - Public APIs - Intentional moves For future works, I think we could start with crates that are performance critical or currently suffering from unnecessary clones. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
