2010YOUY01 commented on code in PR #18468: URL: https://github.com/apache/datafusion/pull/18468#discussion_r2489615697
########## datafusion/common/src/hash_utils.rs: ########## @@ -140,6 +140,7 @@ fn hash_array_primitive<T>( /// If `rehash==true` this combines the previous hash value in the buffer /// with the new hash using `combine_hashes` #[cfg(not(feature = "force_hash_collisions"))] +#[allow(clippy::needless_pass_by_value)] Review Comment: The arg `array` can safely be taken by reference. However, I believe all current call sites already pass it by moving, so they’re fine. That said, there might be optimization opportunities elsewhere — this `needless_pass_by_value` warning could indicate that some callers are cloning unnecessarily just to make the rust compiler happy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
